Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query constraints for /links-endpoint #244

Merged
merged 2 commits into from Apr 7, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Apr 6, 2020

According to Materials-Consortia/OPTIMADE#217 there is no reason why we cannot apply the full range of query parameters for the /links-endpoint.

This PR removes the constraints set on the query parameters for the /links-endpoint and as a bonus I found an elif that had a note, which said it could be removed after upgrading to pydantic v1, so I removed it... Looking around the code, I can't see why I shouldn't be able to do so.

@CasperWA CasperWA added enhancement New feature or request priority/medium Issue or PR with a consensus of medium priority labels Apr 6, 2020
@CasperWA CasperWA requested review from ml-evs and shyamd April 6, 2020 14:49
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #244 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   87.53%   87.62%   +0.09%     
==========================================
  Files          45       45              
  Lines        1941     1932       -9     
==========================================
- Hits         1699     1693       -6     
+ Misses        242      239       -3     
Flag Coverage Δ
#unittests 87.62% <ø> (+0.09%) ⬆️
Impacted Files Coverage Δ
optimade/server/routers/links.py 100.00% <ø> (+10.00%) ⬆️
optimade/server/routers/utils.py 96.94% <ø> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfd51f...962dd90. Read the comment docs.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice that we're getting to the stage where we can remove code :)

@CasperWA CasperWA merged commit d34f7a5 into Materials-Consortia:master Apr 7, 2020
@CasperWA CasperWA deleted the add_pageing_for_links branch April 7, 2020 13:54
@CasperWA CasperWA mentioned this pull request Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium Issue or PR with a consensus of medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants