Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Path.home() instead of ~ #246

Merged
merged 1 commit into from Apr 8, 2020
Merged

Use Path.home() instead of ~ #246

merged 1 commit into from Apr 8, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Apr 8, 2020

Fixes #245

@CasperWA CasperWA requested a review from shyamd April 8, 2020 15:52
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #246 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   87.77%   87.78%           
=======================================
  Files          45       45           
  Lines        1955     1956    +1     
=======================================
+ Hits         1716     1717    +1     
  Misses        239      239
Flag Coverage Δ
#unittests 87.78% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
optimade/server/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a2cbc...ed50839. Read the comment docs.

shyamd
shyamd reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@shyamd shyamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the additional test.

@CasperWA CasperWA merged commit ed50839 into Materials-Consortia:master Apr 8, 2020
@CasperWA CasperWA deleted the fix_245_use_path_home branch April 8, 2020 17:24
@ltalirz ltalirz temporarily deployed to optimade April 8, 2020 17:26 Inactive
@ml-evs ml-evs temporarily deployed to optimade April 14, 2020 15:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamd shyamd shyamd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Path.home() instead of ~ in default config path values
4 participants
@CasperWA @shyamd @ltalirz @ml-evs