Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.1 hotfix #256

Merged
merged 1 commit into from Apr 25, 2020
Merged

v0.8.1 hotfix #256

merged 1 commit into from Apr 25, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 24, 2020

Bug fixes:

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files          54       54           
  Lines        2220     2220           
=======================================
  Hits         1983     1983           
  Misses        237      237           
Flag Coverage Δ
#unittests 89.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20323c6...652bdbc. Read the comment docs.

@ml-evs
Copy link
Member Author

ml-evs commented Apr 24, 2020

@CasperWA can I just double-check; have you been adding the release description as the tag message (in git) or as the release description (in github)?

@ml-evs ml-evs requested a review from CasperWA April 24, 2020 16:20
@CasperWA
Copy link
Member

@CasperWA can I just double-check; have you been adding the release description as the tag message (in git) or as the release description (in github)?

Both - that way I only had to do it once, since the GitHub release from a tag will automatically use the tag message for a description.
I simply copy in the raw PR OP when creating the tag, since I still create the tag on the master branch after the PR has been merged, which is still the way to go unless you merge the PR from your terminal (using merge --ff-only and then pushing the updated master branch). Since this is the only way to keep the latest commit that the tag is pointing to, also be the latest commit merged into master.

That was a long and roundabout answer - I hope it made sense, otherwise please write :)

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an important fix for our Heroku server (and any other as well, naturally).
Cheers @ml-evs (and @shyamd for the fix).

@ml-evs ml-evs merged commit 05b5e15 into master Apr 25, 2020
@CasperWA CasperWA deleted the hotfix_v0.8.1 branch June 2, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants