Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax HTTP URL constraints on meta->implementation->source_url field. #262

Merged
merged 1 commit into from May 4, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 4, 2020

As above, and from #258 & #260.

I also notice that we don't have any real tests for the info models directly, which I guess we should rectify at some point.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files          54       54           
  Lines        2220     2220           
=======================================
  Hits         1983     1983           
  Misses        237      237           
Flag Coverage Δ
#unittests 89.32% <100.00%> (ø)
Impacted Files Coverage Δ
optimade/models/optimade_json.py 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b5e15...e863ea9. Read the comment docs.

@ml-evs ml-evs requested review from CasperWA and fekad May 4, 2020 13:42
@fekad fekad merged commit 2eddcb7 into master May 4, 2020
@ml-evs ml-evs deleted the ml-evs/update_models branch May 4, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants