Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use heroku-shields instead of heroku-badge #284

Merged
merged 1 commit into from May 30, 2020

Conversation

CasperWA
Copy link
Member

We can now add a logo to the badge and still have testing of whether heroku is up or not.

Might as well update this as well 馃槃

The heroku instance we usually use to get the badge is down and is quite rigid. This new one is up and let's us use shield.io better. The new one is using this.

It looks thus:
Heroku App Status

We can now add a logo to the badge and still have testing of whether
heroku is up or not.
@CasperWA CasperWA requested review from fekad and ml-evs May 29, 2020 23:19
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files          54       54           
  Lines        2269     2269           
=======================================
  Hits         2043     2043           
  Misses        226      226           
Flag Coverage 螖
#unittests 90.03% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a1c9f46...be87d93. Read the comment docs.

@ml-evs ml-evs merged commit 758baac into Materials-Consortia:master May 30, 2020
@CasperWA CasperWA deleted the update_heroku_badge branch June 2, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants