Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup MKDocs for Documentation #294
Setup MKDocs for Documentation #294
Changes from 4 commits
c23ea51
7f2fba8
f77953a
1650ab1
27bcf60
ead2465
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right URL?
materials-consortia.github.io
redirects tooptimade.org
, so I guess this should either go tooptimade.org/optimade-python-tools
(if we get someone to update the domain settings for us) or tooptimade-python-tools.github.io
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good point. I don't know what happens to project repo pages when the org page is redirected...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way we can test it before merging? Guess we need to enable Pages for this repo for one (will leave that to you when you're ready)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://materials-consortia.github.io/optimade-python-tools
goes to a 404 under github pages so I think should work. I can't test the deploy until this is merged in asmkdocs gh-deploy
uses the currentremote
to find thegh-pages
branch. That being said, the docs will still work. Just the link back to the docs won't initially.