Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs #295

Merged
merged 19 commits into from Jun 10, 2020
Merged

Update Docs #295

merged 19 commits into from Jun 10, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jun 9, 2020

This PR updates the documentation structure to autogenerate the navigation for the API docs. This also adds the first version of the autogenerated changelog.

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files          54       54           
  Lines        2273     2273           
=======================================
  Hits         2047     2047           
  Misses        226      226           
Flag Coverage Δ
#unittests 90.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8651cd5...07dd779. Read the comment docs.

@shyamd shyamd requested review from ml-evs and CasperWA June 9, 2020 15:08
@shyamd
Copy link
Contributor Author

shyamd commented Jun 9, 2020

Just realized the changelog is pointing to my fork. Let me fix that first.

@CasperWA
Copy link
Member

CasperWA commented Jun 9, 2020

Just realized the changelog is pointing to my fork. Let me fix that first.

I think for this week we should try to not use our own forks (unless you feel more comfortable doing this). But it makes it much easier to quickly retrieve a branch and contribute to it, if needed, before merging.
We should mention this in the presentation shortly as well (@ml-evs) :)

@shyamd
Copy link
Contributor Author

shyamd commented Jun 9, 2020

Ah! I'm so used to using my fork, that I didn't even think about that. I have updated the changelog. This should be good to merge if the tests all pass.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to accept this for a squash merge, would be good to merge this soon so we can continue iterating on it.

@shyamd shyamd merged commit fb50f92 into Materials-Consortia:master Jun 10, 2020
@ml-evs
Copy link
Member

ml-evs commented Jun 10, 2020

Looks like the deployment failed somehow, I don't see any updates on the gh_pages branch from this PR

@shyamd
Copy link
Contributor Author

shyamd commented Jun 10, 2020

It's actually set to just update docs on publishing a new package. We can manually push docs by running mkdocs gh-deploy while on the main repo git. In the future, we'll want to protect that branch and make it so only the github workflow can push to it.

@shyamd
Copy link
Contributor Author

shyamd commented Jun 10, 2020

Just pushed the docs. Changes should be visible shortly

@ml-evs
Copy link
Member

ml-evs commented Jun 11, 2020

I see it all now, great. Couple of comments:

@ml-evs
Copy link
Member

ml-evs commented Jun 11, 2020

Actually I'll raise this as a new issue, though I fear you might be the only one qualified to fix it :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants