Seperated Links from JSON API into its own file #30
Conversation
Links was modified by the Optimade API from the standard JSON API. I moved it to a different file to reflect this change
I added the base Links class because it is needed in JSONApi. I just define next, since pydantic does not allow additionalProperties
I was in the process of changing that yesterday before dinner |
Removed ciricular refrences and remade an attributes definition to follow optimade API's definitions
| """References to other resource objects in a to-one (\"relationship\"). Relationships can be specified by including a member in a resource's links object.""" | ||
|
|
||
| class RelationshipToMany(Set[Linkage]): | ||
| """An array of objects each containing \"type\" and \"id\" members for to-many relationships.""" |
There was a problem hiding this comment.
Just a question: is it necessary to escape quotation marks here?
Does it otherwise break the JSON?
I would have thought pydantic could be a bit more clever...
| meta: Optional[dict] | ||
| links: Optional[ErrorLinks] | ||
|
|
||
| class Links(Links): |
There was a problem hiding this comment.
I find this very ugly, redefinition of the same name when importing something? Looks like a problem waiting to happen
There was a problem hiding this comment.
you could simply from .jsonapi import Links as JSONLinks
There was a problem hiding this comment.
My preference here would be to just import the namespace and then use jsonapi.Links as the base class.
Added missing file changes, and did a minor refactor on Error
Also removed Realtionships as it is not valid
…ade-python-tools into links_seperated Manually fixed merge errors on my local machine
Links was modified by the Optimade API from the standard JSON API. I moved it to a different file
to reflect this change