New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean Up Build Environment #301
Conversation
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 90.11% 90.56% +0.44%
==========================================
Files 55 55
Lines 2287 2268 -19
==========================================
- Hits 2061 2054 -7
+ Misses 226 214 -12
Continue to review full report at Codecov.
|
I forgot to mention that there's a new client dependency (from #297), namely |
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…ools into clean-build-env
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor change requests.
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…ools into clean-build-env
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…ools into clean-build-env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shyamd !
Finally getting this through, after several iterations and rewrites. Thanks so much!
I'm using this PR to clean up the build environment within the package.
Get version from Git SCM tags<--- This causes problem with the validator action so I switched back and am just using tag parsing andinvoke setver
in the publish workflow