Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Build Environment #301

Merged
merged 61 commits into from Jun 11, 2020
Merged

Clean Up Build Environment #301

merged 61 commits into from Jun 11, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jun 10, 2020

I'm using this PR to clean up the build environment within the package.

  • Run pre-commit lint on all files
  • Make some tests a bit more robust
  • Translate bash scripts into invoke tasks
  • Setup dependencies to be managed by dependabot
  • Get version from Git SCM tags <--- This causes problem with the validator action so I switched back and am just using tag parsing and invoke setver in the publish workflow

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #301 into master will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   90.11%   90.56%   +0.44%     
==========================================
  Files          55       55              
  Lines        2287     2268      -19     
==========================================
- Hits         2061     2054       -7     
+ Misses        226      214      -12     
Flag Coverage Δ
#unittests 90.56% <ø> (+0.44%) ⬆️
Impacted Files Coverage Δ
optimade/server/main.py 85.71% <ø> (+7.74%) ⬆️
optimade/server/main_index.py 90.47% <ø> (+10.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ea60a...b349e07. Read the comment docs.

@CasperWA
Copy link
Member

I forgot to mention that there's a new client dependency (from #297), namely jarvis.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor change requests.

.dependabot/config.yml Outdated Show resolved Hide resolved
.github/workflows/deps_lint.yml Outdated Show resolved Hide resolved
.github/workflows/deps_lint.yml Outdated Show resolved Hide resolved
.github/workflows/publish-on-pypi.yml Show resolved Hide resolved
.github/workflows/publish-on-pypi.yml Show resolved Hide resolved
.github/workflows/publish-on-pypi.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
CasperWA and others added 7 commits June 12, 2020 00:19
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
tasks.py Outdated Show resolved Hide resolved
shyamd and others added 3 commits June 11, 2020 16:00
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shyamd !

Finally getting this through, after several iterations and rewrites. Thanks so much!

@CasperWA CasperWA merged commit c2ae80f into Materials-Consortia:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants