Add special species for adapters testing #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a structure with a species that only has chemical_symbols=["X"]. Update ASE conversion to handle this scenario as well as update AiiDA testing of this scenario.
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 90.03% 90.04%
=======================================
Files 54 54
Lines 2268 2270 +2
=======================================
+ Hits 2042 2044 +2
Misses 226 226
Continue to review full report at Codecov.
|
CasperWA
added a commit
to knc6/optimade-python-tools
that referenced
this pull request
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304
Add a structure with a species that only has chemical_symbols=["X"].
Update ASE conversion to handle this scenario as well as update AiiDA testing of this scenario.