Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent the datetime objects as UTC in RFC3339 format #333

Merged
merged 6 commits into from Jun 15, 2020

Conversation

fekad
Copy link
Contributor

@fekad fekad commented Jun 12, 2020

Fixing #288

According to the conversation in the issue, the response always returns with the UTC time in RFC3339 format even if it is not aligned to the actual timezone where the API is running.

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #333 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   90.56%   90.57%   +0.01%     
==========================================
  Files          55       55              
  Lines        2268     2271       +3     
==========================================
+ Hits         2054     2057       +3     
  Misses        214      214              
Flag Coverage Δ
#unittests 90.57% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
optimade/server/routers/utils.py 97.72% <ø> (ø)
optimade/models/jsonapi.py 90.52% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904cb5f...72241ed. Read the comment docs.

This reverts commit be037a8.
@fekad fekad requested review from shyamd and CasperWA June 12, 2020 11:08
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fekad !

I've put it some comments/questions.

INSTALL.md Show resolved Hide resolved
optimade/server/routers/utils.py Show resolved Hide resolved
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @fekad for the detailed analysis on top of this 👍

@CasperWA CasperWA merged commit f62cc4d into master Jun 15, 2020
@CasperWA CasperWA deleted the fix_288_datetime branch June 15, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants