Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default implementation information #372

Merged
merged 4 commits into from Jun 25, 2020
Merged

Update default implementation information #372

merged 4 commits into from Jun 25, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jun 25, 2020

Updates the default implementation information to point to this "official" python implementation.

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          54       54           
  Lines        2386     2386           
=======================================
  Hits         2154     2154           
  Misses        232      232           
Flag Coverage Δ
#unittests 90.27% <ø> (ø)
Impacted Files Coverage Δ
optimade/server/config.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271a34d...1d2578d. Read the comment docs.

@shyamd shyamd requested a review from ml-evs June 25, 2020 18:55
@CasperWA
Copy link
Member

Squash merge at will

@shyamd shyamd merged commit 4c299e2 into master Jun 25, 2020
@CasperWA CasperWA deleted the shyamd-patch-1 branch June 25, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants