Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish workflow - final(TM) fix #378

Merged
merged 1 commit into from Jun 28, 2020

Conversation

CasperWA
Copy link
Member

So it seems the new publish workflow sort of worked - only it didn't actually publish correctly on PyPI.
This was due to the fact that the local checked out version was wrong, and still the original one prior to updating the version, changelog and all.
This fix moves the step, where the tag is force pushed to the newest commit up before the creation of the source distribution and subsequent publishing on PyPI. This will automatically checkout the newly created commit as well.

Also, up the pre-sleep time before "waiting" in the new Action publish workflow to 15 seconds (default is 5 seconds).

This also shaves down the .gitignore file, trying to remove all the unrelevant lines.

Updating the tag prior to publishing on PyPI retrieves the newly created
version as well as updates the tag to the newly created commit.

Now the created source distribution uses the newly created commit with
its new version and all.
@CasperWA CasperWA added the bug Something isn't working label Jun 28, 2020
@CasperWA CasperWA requested review from ml-evs and shyamd June 28, 2020 12:30
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          54       54           
  Lines        2386     2386           
=======================================
  Hits         2154     2154           
  Misses        232      232           
Flag Coverage Δ
#unittests 90.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8c5ef...80193a7. Read the comment docs.

@shyamd
Copy link
Contributor

shyamd commented Jun 28, 2020

What happened to the invoke task that actually sets the version?

@CasperWA
Copy link
Member Author

CasperWA commented Jun 28, 2020

What happened to the invoke task that actually sets the version?

It works fine. It's just that the action makes all the changes and push upstream within a separate Docker container, hence when it leaves the action, we're still on the original checkout of the repository.
So a git fetch is needed, essentially. Which coincides well with force pushing the created tag to the newly created commit (from the Docker container-action).

@shyamd
Copy link
Contributor

shyamd commented Jun 28, 2020

Sounds good. Let's try this again. :P

@CasperWA CasperWA merged commit 998fbe3 into Materials-Consortia:master Jun 28, 2020
@CasperWA CasperWA deleted the minor_publish_update branch June 28, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants