Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pytest instead of unittest #390

Merged
merged 9 commits into from
Jul 16, 2020
Merged

Use pytest instead of unittest #390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cc8334a
Only run pytests from tests/
CasperWA Jul 4, 2020
8ddf2e9
Starting to convert from unittest to pytest
CasperWA Jul 4, 2020
b3f9c44
Update the rest of the tests to pytest
CasperWA Jul 4, 2020
fa9b400
Add tests for `sort`
CasperWA Jul 4, 2020
83b5aed
Update tests/server/conftest.py
CasperWA Jul 10, 2020
79a46be
Update according to review by @ml-evs
CasperWA Jul 15, 2020
53c84f3
Update tests/server/utils.py
CasperWA Jul 15, 2020
cedc90f
Update all CI to Python 3.8 by default
CasperWA Jul 16, 2020
89db721
Use static requirement versions for pre-commit CI
ml-evs Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/server/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ def inner(

if expected_detail is None:
expected_detail = "Error trying to process rule "
CasperWA marked this conversation as resolved.
Show resolved Hide resolved
assert error["detail"].startswith(expected_detail), error
assert error["detail"].startswith(expected_detail), (
"No expected_detail provided and the error did not start with a standard Lark "
"error message."
)
else:
assert expected_detail == error["detail"], error

Expand Down
14 changes: 7 additions & 7 deletions tests/server/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def check_keys(keys: list, response_subset: typing.Iterable):
for key in keys:
assert (
key in response_subset
), f"{key} missing from response {response_subset}"
), f"{key!r} missing from response {response_subset}"
ml-evs marked this conversation as resolved.
Show resolved Hide resolved

def test_response_okay(self):
"""Make sure the response was successful"""
Expand All @@ -129,18 +129,18 @@ def test_meta_response(self):
set(ResponseMeta.schema()["properties"].keys()) - set(meta_required_keys)
)
implemented_optional_keys = [
# "schema",
"time_stamp",
"data_returned",
"provider",
"data_available",
"implementation",
# These keys are not implemented in the example server implementations
CasperWA marked this conversation as resolved.
Show resolved Hide resolved
# Add them in when they are.
# "schema",
# "last_id",
# "response_message",
# "warnings",
]
# meta_may_keys = [
# "last_id",
# "response_message",
# "warnings",
# ]

self.check_keys(meta_required_keys, self.json_response["meta"])
self.check_keys(implemented_optional_keys, meta_optional_keys)
Expand Down