New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily run AiiDA tests on Python 3.8 only #400
Conversation
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 90.24% 89.62% -0.62%
==========================================
Files 55 55
Lines 2408 2459 +51
==========================================
+ Hits 2173 2204 +31
- Misses 235 255 +20
Continue to review full report at Codecov.
|
Will use that aforementioned executive privilege to merge this in a few minutes without review... @CasperWA |
So we couldn't fix to 3.7.7 for python 3.7? |
We can, but I don't think we want to (we'd have to run coverage on a different version anyway, as gh actions doesn't let you compare versions with patch numbers in them atm...). I'd rather let this be fixed upstream in AiiDA rather than pinning us to an old Python version. |
Following the discussion in #395, and also in actions/setup-python#107, easiest thing for us to do for now is to run the AiiDA tests on Python 3.8 only, then relax the requirement on future versions.