Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily run AiiDA tests on Python 3.8 only #400

Merged
merged 2 commits into from Jul 10, 2020
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jul 10, 2020

Following the discussion in #395, and also in actions/setup-python#107, easiest thing for us to do for now is to run the AiiDA tests on Python 3.8 only, then relax the requirement on future versions.

@ml-evs ml-evs changed the title Attempts to fix build issues with Python 3.7.8 Run AiiDA tests on Python 3.8 only Jul 10, 2020
@ml-evs ml-evs changed the title Run AiiDA tests on Python 3.8 only Temporarily run AiiDA tests on Python 3.8 only Jul 10, 2020
@ml-evs ml-evs requested a review from CasperWA July 10, 2020 14:58
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #400 into master will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   90.24%   89.62%   -0.62%     
==========================================
  Files          55       55              
  Lines        2408     2459      +51     
==========================================
+ Hits         2173     2204      +31     
- Misses        235      255      +20     
Flag Coverage Δ
#unittests 89.62% <ø> (-0.62%) ⬇️
Impacted Files Coverage Δ
optimade/adapters/structures/aiida.py 41.93% <0.00%> (-58.07%) ⬇️
optimade/server/config.py 96.15% <0.00%> (-3.85%) ⬇️
optimade/models/links.py 100.00% <0.00%> (ø)
optimade/adapters/base.py 100.00% <0.00%> (ø)
optimade/models/entries.py 100.00% <0.00%> (ø)
optimade/models/references.py 97.67% <0.00%> (+0.05%) ⬆️
optimade/models/responses.py 97.56% <0.00%> (+0.06%) ⬆️
optimade/filtertransformers/mongo.py 97.15% <0.00%> (+0.12%) ⬆️
optimade/validator/validator.py 74.47% <0.00%> (+0.17%) ⬆️
optimade/models/optimade_json.py 94.18% <0.00%> (+0.21%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf092ea...7d658f8. Read the comment docs.

@ml-evs
Copy link
Member Author

ml-evs commented Jul 10, 2020

Will use that aforementioned executive privilege to merge this in a few minutes without review... @CasperWA

@CasperWA
Copy link
Member

So we couldn't fix to 3.7.7 for python 3.7?

@ml-evs
Copy link
Member Author

ml-evs commented Jul 10, 2020

So we couldn't fix to 3.7.7 for python 3.7?

We can, but I don't think we want to (we'd have to run coverage on a different version anyway, as gh actions doesn't let you compare versions with patch numbers in them atm...). I'd rather let this be fixed upstream in AiiDA rather than pinning us to an old Python version.

@ml-evs ml-evs merged commit b93ff20 into master Jul 10, 2020
@CasperWA CasperWA deleted the ml-evs/CI_fixes branch September 15, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants