Fix /vMAJOR/info in index server #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test all versioned base URLs' routers return status code 200.
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 90.95% 90.99% +0.03%
==========================================
Files 55 55
Lines 2522 2522
==========================================
+ Hits 2294 2295 +1
+ Misses 228 227 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
CasperWA
force-pushed
the
fix_index_server
branch
2 times, most recently
from
1f3ea42
to
782868d
Compare
|
From this CI run: https://github.com/Materials-Consortia/optimade-python-tools/runs/881814874?check_suite_focus=true |
ml-evs
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the
/infoendpoint was not initiated for/vMAJOR.Test all versioned base URLs' routers return status code 200.
Locally, I still can't reachWith a small break and a reinstall it seems fine... weird./v1/infofor the index meta-database implementation in the test. I am unsure what the exact issue is now.Finally, I tried to originally add the landing router as well, but there seems to be some issues with Jinja2 templates and middleware for the Starlette
TestClient.See the issues encode/starlette#472 and tiangolo/fastapi#806.
I will leave this for a later point, perhaps an issue of our own to decide on what approach to take, since there are a few work-arounds.