Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update more unittest tests to pytest #425

Merged
merged 2 commits into from Jul 22, 2020

Conversation

CasperWA
Copy link
Member

The filter* tests were still unittests.

This turns them into proper pytests.

@CasperWA CasperWA requested a review from ml-evs July 22, 2020 16:55
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files          55       55           
  Lines        2522     2522           
=======================================
  Hits         2295     2295           
  Misses        227      227           
Flag Coverage Δ
#unittests 90.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d94d7d...4b81b9c. Read the comment docs.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see any problems with this, nice work @CasperWA. I touch a few bits of this in the sorting PR, so we should merge this first and I'll add the extra tests pytest style.

@CasperWA CasperWA merged commit c0a1857 into Materials-Consortia:master Jul 22, 2020
@CasperWA CasperWA deleted the more_pytest_tests branch July 22, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants