Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch OSError instead of PermissionError when making log dir #449

Merged
merged 1 commit into from Aug 3, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Aug 2, 2020

Fixes #448

@CasperWA CasperWA requested review from ml-evs and shyamd August 2, 2020 21:06
@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files          60       60           
  Lines        2800     2800           
=======================================
  Hits         2565     2565           
  Misses        235      235           
Flag Coverage Δ
#unittests 91.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/logger.py 76.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033800d...91efeba. Read the comment docs.

@ml-evs ml-evs merged commit 42dd926 into master Aug 3, 2020
@CasperWA CasperWA deleted the fix_448_catch_OSError branch August 3, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heroku is failing - raising OSError when making LOGS_DIR
2 participants