New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate OpenAPI specification in CI #481
Conversation
66fe896
to
99d148b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not many comments right now. As we're discussing on Slack as well, I'll just recap a bit:
- Possibly use POST instead to send the latest generated
openapi.json
as well asindex_openapi.json
content. - Add the badge to the README (possibly).
In addition, I think we should remove openapi-spec-validator
as a dependency and all uses of it.
0c560c0
to
feb0eeb
Compare
Agreed, I've just replaced the openapi CI task with this. |
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 60 60
Lines 2848 2848
=======================================
Hits 2611 2611
Misses 237 237
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Co-authored-by: Casper Welzel Andersen <CasperWA@users.noreply.github.com>
dfbb8d7
to
5695cb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great now. A final simplification from my side.
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
RE: readme badge, would you want it to just point to the master version of |
Yeah, that was my idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great with one less (direct) dependency, thanks @ml-evs !
This PR adds an invoke task to get the response from https://validator.swagger.io/debug for a given URL. The CI then uses the commit SHA/repository to construct the URL for our OpenAPI schema, currently hard-coded to be at
openapi/openapi.json
andopenapi/index_openapi.json
, which it then pings the validator with.