Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/structure/info endpoint #49

Merged
merged 2 commits into from Jun 21, 2019
Merged

/structure/info endpoint #49

merged 2 commits into from Jun 21, 2019

Conversation

fawzi
Copy link
Contributor

@fawzi fawzi commented Jun 16, 2019

Adding structures/info endpoint, minor fixes to info (no spurious params, json->jsonapi)

@fawzi
Copy link
Contributor Author

fawzi commented Jun 16, 2019

eheh we have a good testing, indeed this commit breaks backward compatibility, but having the parameters in info was a mistake, and not spec compliant...

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @fawzi, I'm happy to accept this as is, but I have one comment (see below).

@dwinston dwinston merged commit c78b2cd into master Jun 21, 2019
@CasperWA CasperWA deleted the structure_info branch November 8, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants