Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py and version #51

Merged
merged 6 commits into from Jun 25, 2019
Merged

Update setup.py and version #51

merged 6 commits into from Jun 25, 2019

Conversation

dwinston
Copy link
Contributor

@dwinston dwinston commented Jun 21, 2019 •
edited

  • Bumps internal minor version (0.1.x to 0.2.0) for release to PyPi
  • Updates setup.py metadata to reflect current authorship

ltalirz
ltalirz previously approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dwinston !

@ltalirz
Copy link
Member

ltalirz commented Jun 21, 2019

Oh, I see, there's new validation errors...

@ltalirz ltalirz dismissed their stale review June 21, 2019 16:06

validation errors...

@dwinston
Copy link
Contributor Author

Interesting. The schema generates without error for fastapi 0.29.1, but not for fastapi 0.20.0. I'll see what's going on...

@dwinston
Copy link
Contributor Author

Okay, I think it's this reported bug in pydantic 0.28. I implemented the two-line proposed fix to pydantic, and the schema generates properly in this case. So, we need to wait for the fix to pydantic (and corresponding updated dep in fastapi) to upgrade fastapi. Whew!

@ltalirz
Copy link
Member

ltalirz commented Jun 21, 2019

@dwinston did you still want to push?

@dwinston
Copy link
Contributor Author

I’d like to wait for the fastapi/pydantic fix upstream and then update this PR with the later version(s) so that the tests pass.

@dwinston dwinston changed the title Bump reqs / update setup.py Update setup.py and version Jun 24, 2019
@dwinston
Copy link
Contributor Author

Forget it -- I've removed the non-fastapi updates so that this passes tests and we can get updated setup.py info and push a new version to PyPI.

@dwinston dwinston requested a review from ltalirz June 24, 2019 23:20
@ml-evs
Copy link
Member

ml-evs commented Jun 25, 2019

lgtm, merge whenever you're ready

@ltalirz ltalirz merged commit 59d3c46 into master Jun 25, 2019
@dwinston dwinston deleted the bump-reqs branch June 26, 2019 00:10
@ltalirz ltalirz mentioned this pull request Jun 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltalirz ltalirz ltalirz approved these changes

@ml-evs ml-evs ml-evs approved these changes

@fawzi fawzi Awaiting requested review from fawzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dwinston @ltalirz @ml-evs