Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CONFIG import so it does not get triggered when just importing mapper #569

Merged
merged 2 commits into from Nov 2, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 27, 2020

This is to suppress the spurious warning reported in #568. Alternatively, we could consider making another level in the mapper hierarchy (ReallyBaseMapper...) that does not touch the config.

Closes #568.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #569 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          62       62           
  Lines        3221     3222    +1     
=======================================
+ Hits         2956     2957    +1     
  Misses        265      265           
Flag Coverage Δ
project 91.77% <100.00%> (+<0.01%) ⬆️
validator 64.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/mappers/entries.py 98.33% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a190a...b2b077f. Read the comment docs.

@ml-evs ml-evs force-pushed the ml-evs/remove_spurious_config_warning branch from 7f9e054 to 7a76245 Compare October 27, 2020 19:50
@ml-evs ml-evs requested a review from CasperWA October 28, 2020 21:29
@CasperWA CasperWA merged commit e7a8de9 into master Nov 2, 2020
@CasperWA CasperWA deleted the ml-evs/remove_spurious_config_warning branch November 2, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete output of optimade-validator
2 participants