New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --minimal/--page_limit validator options and remove old code #571
Conversation
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
+ Coverage 91.77% 92.11% +0.34%
==========================================
Files 62 61 -1
Lines 3220 3210 -10
==========================================
+ Hits 2955 2957 +2
+ Misses 265 253 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is page_limit
applied?
Any time the validator hits a multi-entry endpoint, at the moment it always uses the default 5 but there doesn't seem much point in not making this configurable |
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
In the code, I only see the addition of the option, but never the actual use of this option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers @ml-evs !
--minimal
which skips the slow-running query tests on each endpoint.--page_limit
which can override the default page limit of 5.optimade.validator.data
submodule.