Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --minimal/--page_limit validator options and remove old code #571

Merged
merged 7 commits into from Nov 4, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 28, 2020

  • Adds --minimal which skips the slow-running query tests on each endpoint.
  • Adds --page_limit which can override the default page limit of 5.
  • Slightly tweaks which function reports the error if single entry endpoint tests cannot be performed
  • Removes the now defunct optimade.validator.data submodule.

@ml-evs ml-evs added priority/low Issue or PR with a consensus of low priority validator Related to the OPTIMADE validator labels Oct 28, 2020
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #571 into master will increase coverage by 0.34%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   91.77%   92.11%   +0.34%     
==========================================
  Files          62       61       -1     
  Lines        3220     3210      -10     
==========================================
+ Hits         2955     2957       +2     
+ Misses        265      253      -12     
Flag Coverage Δ
project 92.11% <77.77%> (+0.34%) ⬆️
validator 64.95% <77.77%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/__init__.py 8.57% <0.00%> (-0.52%) ⬇️
optimade/validator/validator.py 82.26% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7700324...91a980a. Read the comment docs.

@ml-evs ml-evs requested a review from CasperWA October 28, 2020 23:29
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is page_limit applied?

optimade/validator/__init__.py Outdated Show resolved Hide resolved
@ml-evs
Copy link
Member Author

ml-evs commented Nov 2, 2020

Where is page_limit applied?

Any time the validator hits a multi-entry endpoint, at the moment it always uses the default 5 but there doesn't seem much point in not making this configurable

ml-evs and others added 2 commits November 2, 2020 19:13
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
@CasperWA
Copy link
Member

CasperWA commented Nov 2, 2020

Where is page_limit applied?

Any time the validator hits a multi-entry endpoint, at the moment it always uses the default 5 but there doesn't seem much point in not making this configurable

In the code, I only see the addition of the option, but never the actual use of this option.
If it's not used or fixed, then maybe we don't add it?

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @ml-evs !

@ml-evs ml-evs merged commit 7e932df into master Nov 4, 2020
@ml-evs ml-evs deleted the ml-evs/add_validator_options branch June 1, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Issue or PR with a consensus of low priority validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants