Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for the validator #610

Merged
merged 2 commits into from Nov 23, 2020
Merged

Minor fixes for the validator #610

merged 2 commits into from Nov 23, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 22, 2020

  • Test for 553 Version Not Supported is now optional as its only a SHOULD in the specification
  • Fix optional test output colour
  • Removed extraneous punctuation from link
  • Made response field errors non-fatal

@ml-evs
Made test for returning 553 on unsupported versions optional as it is…
905e41e 
… only a SHOULD in the specification
@ml-evs
A few minor fixes:
4c17923 
- Fix optional test output colour
- Removed extraneous punctuation from link
- Made response field errors non-fatal
@ml-evs ml-evs added the validator Related to the OPTIMADE validator label Nov 22, 2020
@codecov
Copy link

codecov bot commented Nov 22, 2020 •
edited

Codecov Report

Merging #610 (4c17923) into master (e2531fb) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files          61       61           
  Lines        3246     3246           
=======================================
  Hits         2993     2993           
  Misses        253      253
Flag Coverage Δ
project 92.20% <33.33%> (ø)
validator 65.89% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/utils.py 94.63% <ø> (ø)
optimade/validator/validator.py 82.26% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2531fb...4c17923. Read the comment docs.

@ml-evs ml-evs requested a review from CasperWA November 22, 2020 21:00
CasperWA
CasperWA approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, cheers @ml-evs

@ml-evs
Copy link
Member Author

ml-evs commented Nov 23, 2020

All looks good, cheers @ml-evs

It allows us to kick the can of #520 down the road too...

@ml-evs ml-evs merged commit 89227d3 into master Nov 23, 2020
@ml-evs ml-evs deleted the ml-evs/validator_fixes branch November 23, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

Assignees
No one assigned
Labels
validator Related to the OPTIMADE validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ml-evs @CasperWA