Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream fixes from specification #611

Merged
merged 2 commits into from Nov 25, 2020
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 23, 2020

This PR simply adds some fixes (typos/missing examples) from the specification into our models.

@ml-evs ml-evs added schema Concerns the schema models priority/medium Issue or PR with a consensus of medium priority models For issues related to the pydantic models directly labels Nov 23, 2020
@ml-evs ml-evs requested a review from CasperWA November 23, 2020 13:53
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #611 (5e96ac1) into master (89227d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files          61       61           
  Lines        3246     3246           
=======================================
  Hits         2993     2993           
  Misses        253      253           
Flag Coverage Δ
project 92.20% <ø> (ø)
validator 65.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/models/structures.py 96.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89227d3...5e96ac1. Read the comment docs.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @ml-evs

@ml-evs ml-evs merged commit bf1f280 into master Nov 25, 2020
@ml-evs ml-evs deleted the ml-evs/fixes_from_upstream branch June 1, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models For issues related to the pydantic models directly priority/medium Issue or PR with a consensus of medium priority schema Concerns the schema models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants