Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validation error to warning on empty endpoints #621

Merged
merged 1 commit into from Dec 4, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 4, 2020

Closes #622.

@ml-evs ml-evs added priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator labels Dec 4, 2020
@ml-evs ml-evs requested a review from CasperWA December 4, 2020 20:17
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #621 (b8a08ab) into master (1ffb03d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #621   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files          61       61           
  Lines        3246     3246           
=======================================
  Hits         2993     2993           
  Misses        253      253           
Flag Coverage Δ
project 92.20% <0.00%> (ø)
validator 65.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/validator.py 82.26% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffb03d...b8a08ab. Read the comment docs.

@ml-evs
Copy link
Member Author

ml-evs commented Dec 4, 2020

Self-merging, as this is a tiny but useful change.

@ml-evs ml-evs merged commit f79da65 into master Dec 4, 2020
@ml-evs ml-evs deleted the ml-evs/allow_empty_endpoints branch December 4, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty endpoints raise errors on validation
1 participant