Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPI publishing in CI #623

Merged
merged 1 commit into from Dec 5, 2020
Merged

Fix PyPI publishing in CI #623

merged 1 commit into from Dec 5, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 4, 2020

The new pip dependency resolver now actually resolves dependencies, causing mayhem. Somehow one of aiida's dependencies doesn't like the latest setuptools version, so this PR switches back to the legacy resolver temporarily.

Aims to close #624.

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #623 (0417216) into master (f79da65) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files          61       61           
  Lines        3246     3246           
=======================================
  Hits         2993     2993           
  Misses        253      253           
Flag Coverage Δ
project 92.20% <ø> (ø)
validator 65.89% <ø> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79da65...0417216. Read the comment docs.

@CasperWA
Copy link
Member

CasperWA commented Dec 5, 2020

Well you write one thing in the OP and have done another, hehe. I have found this issue in my local installation as well when trying to update the installation I have of optimade[all].
I am surprised this is not caught in our CI tests - I guess it's because the resolver is not applied when installing with -r? Or is it the order of installing the dependencies perhaps?

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I'll approve this for now as we should be able to publish versions at least.
But we should make an issue for this that we should properly test the installation with the newest pip resolver and be as compliant as possible.

@CasperWA CasperWA merged commit f9a286c into master Dec 5, 2020
@CasperWA CasperWA deleted the ml-evs/pypi_fixes branch December 5, 2020 01:14
@ml-evs
Copy link
Member Author

ml-evs commented Dec 5, 2020

Ah whoops, I tried the legacy resolver first then switched the installation order instead, but forgot to push... oh well, needs to be fixed anyway. Thanks for the quick review on this @CasperWA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI publishing build is broken by latest pip
2 participants