Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub CODEOWNERS #664

Merged
merged 3 commits into from Jan 7, 2021
Merged

Added GitHub CODEOWNERS #664

merged 3 commits into from Jan 7, 2021

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 6, 2021

This is to force a review from either @CasperWA or I on all PRs. It would be great to split the package up a bit so that other contributors have some ownership. We will hopefully discuss this in the meeting today.

In the meeting we decided to also add other owners for mongo and elastic specifically (I won't tag Markus or Shyam again to avoid spam).

@ml-evs ml-evs requested a review from CasperWA January 6, 2021 13:19
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #664 (2fa6575) into master (790ab7d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          61       61           
  Lines        3299     3299           
=======================================
  Hits         3083     3083           
  Misses        216      216           
Flag Coverage Δ
project 93.45% <ø> (ø)
validator 66.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790ab7d...2fa6575. Read the comment docs.

@shyamd shyamd self-requested a review January 7, 2021 15:48
@ml-evs ml-evs merged commit 33de78f into master Jan 7, 2021
@ml-evs ml-evs deleted the ml-evs/add_codeowners branch January 7, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants