New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to README and docs for v0.10.0 #68
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 82.81% 82.81%
=======================================
Files 39 39
Lines 1810 1810
=======================================
Hits 1499 1499
Misses 311 311
Continue to review full report at Codecov.
|
Nice - did you change anything in the development instructions upon moving them to CONTRIBUTIONS? |
I changed the filename references in the final section about developing new transformers, and added a title. |
Sorry I referred this PR by mistake ( 68 VS #66 ). I already changed the link in the original one. |
9e8b0d5
to
0eb271d
Compare
I have found that for I am open to your suggestions, considerations and opinions on this as well, and I think we should decide on a recommended repository format in this PR. |
I have created an "OPTiMaDe badge". It uses the shield.io endpoint service, where one can pass a URL to a JSON file that defines a badge. (here pointing to the current branch) Note: The file |
Missed all of this, sorry @CasperWA.
I think we need to get this merged before we forget about it, and prepare another docs update for 0.10.1+. |
No worries.
Sure - I will do it. The
The OPTiMaDe batch will not work until this PR is merged into
Okay. I will try to add some information on what I have added to the OP. |
@ml-evs Could you pass through the README and CONTRIBUTIONS? I know you can't really review it, since you opened the PR, but just to check my additions are all right. Then I'll approve and we can merge. |
Add OPTiMaDe version badge using shields.io's endpoint service. One can pass a URL to a JSON file, which will determine the badge. The URL points to a local repository file on the `master` branch. The local repository JSON file is checked during pre-commit, matching against the version in config.ini. A new task `set-optimade-ver` has been implemented, to update the OPTiMaDe version (updates the JSON file and config.ini).
7c771d3
to
ac8c2c9
Compare
Thanks for tidying this up @CasperWA , shall we get it merged? EDIT: Whoops, just seen your comment from before Christmas... will have a closer look... |
Just ping me when you it's ready for a final review and possible merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work with this @ml-evs.
It all looks good to me.
Minor additions, updates or changes may still happen, but this rewrite/upgrade is very much needed.
CONTRIBUTING.md
file.server.cfg
filePlease add any changes to the README or associated files to this PR.