Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update species->mass field #710

Closed
wants to merge 2 commits into from
Closed

Update species->mass field #710

wants to merge 2 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 17, 2021

This PR contains the first two commits from #631 and hopefully closes #630 without needing to update the adapters.

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #710 (dedb941) into master (2f4d721) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #710   +/-   ##
=======================================
  Coverage   93.18%   93.19%           
=======================================
  Files          61       61           
  Lines        3362     3364    +2     
=======================================
+ Hits         3133     3135    +2     
  Misses        229      229           
Flag Coverage Δ
project 93.19% <100.00%> (+<0.01%) ⬆️
validator 66.17% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/models/structures.py 96.38% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4d721...dedb941. Read the comment docs.

@ml-evs
Copy link
Member Author

ml-evs commented Feb 17, 2021

Looks like nothing broke @CasperWA, I would suggest we merge, release 0.12.10 and then update the schema in the spec repo ASAP (i.e. in the next 20 minutes 😁)

@ml-evs ml-evs marked this pull request as ready for review February 17, 2021 14:38
@CasperWA
Copy link
Member

These changes have been incorporated via #631.

@CasperWA CasperWA closed this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update species.mass model
2 participants