Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to "all" endpoint and rename collections submodule #73

Merged
merged 2 commits into from Nov 8, 2019

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 5, 2019

Just a couple of tiny changes that I'm happy to leave out:

  • Removed the "all" endpoint from the default endpoint list in BaseInfo. I couldn't find a reference to this in the spec, so assume it was an old macro? Currently writing a validator that scans "available_endpoints" of a reference implementation and makes requests against them and don't want to have to hardcode ignoring all.
  • Renamed the server.collections submodule as it clashes with the standard library collections, it's not a big deal, but opening vim from that folder was causing it to crash...

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          30       30           
  Lines        1323     1323           
=======================================
  Hits         1134     1134           
  Misses        189      189
Impacted Files Coverage Δ
optimade/models/baseinfo.py 92.3% <ø> (ø) ⬆️
optimade/server/entry_collections.py 82.5% <ø> (ø)
optimade/server/main.py 66.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fa775...2e7e957. Read the comment docs.

@CasperWA
Copy link
Member

CasperWA commented Nov 8, 2019

* Removed the `"all"` endpoint from the default endpoint list in `BaseInfo`. I couldn't find a reference to this in the spec, so assume it was an old macro? (...)

Correct. This endpoint was officially removed from the spec. in v0.10.0.

* Renamed the `server.collections` submodule as it clashes with the standard library `collections`, it's not a big deal, but opening vim from that folder was causing it to crash...

Great! I did this in my local server as well - so very much needed.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me 👍

Thanks @ml-evs!

@CasperWA CasperWA merged commit bb42c6e into master Nov 8, 2019
@CasperWA CasperWA deleted the ml-evs/fixes branch November 8, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants