Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all floating-point comparisons during validation #736

Merged
merged 2 commits into from Mar 8, 2021

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 8, 2021

Closes #735 by disabling floating point comparisons for float fields, and for fields that are inferred to be lists of floats.

@ml-evs ml-evs added priority/medium Issue or PR with a consensus of medium priority validator Related to the OPTIMADE validator labels Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #736 (0289cbe) into master (f77235d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   92.79%   92.78%   -0.02%     
==========================================
  Files          67       67              
  Lines        3526     3533       +7     
==========================================
+ Hits         3272     3278       +6     
- Misses        254      255       +1     
Flag Coverage Δ
project 92.78% <100.00%> (-0.02%) ⬇️
validator 63.62% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/config.py 100.00% <ø> (ø)
optimade/validator/validator.py 82.36% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77235d...0289cbe. Read the comment docs.

@ml-evs ml-evs marked this pull request as ready for review March 8, 2021 18:37
@ml-evs ml-evs requested a review from CasperWA as a code owner March 8, 2021 18:37
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ml-evs !

I only have a very minor insignificant suggested change - it can be ignored or kept as you see fit.

optimade/validator/config.py Show resolved Hide resolved
@ml-evs ml-evs merged commit 9306cb8 into master Mar 8, 2021
@ml-evs ml-evs deleted the ml-evs/disable_float_validation branch March 8, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium Issue or PR with a consensus of medium priority validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating point comparisons should not be tested with the validator
2 participants