Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 400 Bad Request (not 500) on filter parser errors, plus filterparser module facelift #813

Merged
merged 2 commits into from May 25, 2021
Merged

Return 400 Bad Request (not 500) on filter parser errors, plus filterparser module facelift #813

merged 2 commits into from May 25, 2021

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 24, 2021 •
edited

Closes #812 by changing filter parsing errors from ParserErrors to BadRequests.

Also adds docstrings, types etc. to the filterparser module.

@ml-evs ml-evs added bug Something isn't working priority/high Issue or PR with a consensus of high priority parser Related to the Lark parser server Issues pertaining to the example server implementation labels May 24, 2021
@ml-evs ml-evs marked this pull request as ready for review May 24, 2021 22:37
JPBergsma
JPBergsma approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine to me.

@ml-evs ml-evs merged commit 3d4e19b into master May 25, 2021
@ml-evs ml-evs deleted the ml-evs/closes_#812 branch May 25, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPBergsma JPBergsma JPBergsma approved these changes

@shyamd shyamd shyamd approved these changes

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA is a code owner

Assignees
No one assigned
Labels
bug Something isn't working parser Related to the Lark parser priority/high Issue or PR with a consensus of high priority server Issues pertaining to the example server implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ParserError's should not return 500 HTTP status codes
3 participants
@ml-evs @shyamd @JPBergsma