Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provider fallback list #830

Merged
merged 1 commit into from Jun 1, 2021
Merged

Fix provider fallback list #830

merged 1 commit into from Jun 1, 2021

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 1, 2021

Closes #829

@ml-evs ml-evs added bug Something isn't working priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation labels Jun 1, 2021
@ml-evs ml-evs marked this pull request as ready for review June 1, 2021 10:40
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #830 (04a3850) into master (2e9507e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files          68       68           
  Lines        3759     3759           
=======================================
  Hits         3484     3484           
  Misses        275      275           
Flag Coverage Δ
project 92.68% <ø> (ø)
validator 92.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/routers/utils.py 98.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9507e...04a3850. Read the comment docs.

@ml-evs
Copy link
Member Author

ml-evs commented Jun 1, 2021

I am going to take executive action and merge this one myself...

@ml-evs ml-evs merged commit 093067b into master Jun 1, 2021
@ml-evs ml-evs deleted the ml-evs/close_#829 branch June 1, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider fallbacks do not get used
1 participant