Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve semver validation error messsage #845

Merged
merged 2 commits into from Jun 9, 2021

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 9, 2021

Minor fix arising from some validation of AFLOW yesterday (that "1.0" is not a valid semver, and also that semver may not be well known as an abbreviation).

@ml-evs ml-evs added priority/low Issue or PR with a consensus of low priority models For issues related to the pydantic models directly labels Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #845 (22f6d55) into master (97c0c89) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #845   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files          67       67           
  Lines        3699     3699           
=======================================
  Hits         3429     3429           
  Misses        270      270           
Flag Coverage Δ
project 92.70% <100.00%> (ø)
validator 92.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/models/utils.py 91.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f80c842...22f6d55. Read the comment docs.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @ml-evs !

@CasperWA CasperWA merged commit c6f9977 into master Jun 9, 2021
@CasperWA CasperWA deleted the ml-evs/improve_semver_error_message branch June 9, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models For issues related to the pydantic models directly priority/low Issue or PR with a consensus of low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants