Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sortable field to EntryInfoProperty model #85

Merged
merged 4 commits into from Nov 20, 2019
Merged

Conversation

CasperWA
Copy link
Member

Fixes #84

Also adds a validator for EntryInfoResource, checking that sortable is either there for all or for none of the properties.

@CasperWA CasperWA added this to In progress in Road to optimade-python-tools 1.0 via automation Nov 15, 2019
@CasperWA CasperWA added the schema Concerns the schema models label Nov 15, 2019
@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #85 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   84.31%   84.32%   +<.01%     
==========================================
  Files          35       35              
  Lines        2098     2099       +1     
==========================================
+ Hits         1769     1770       +1     
  Misses        329      329
Impacted Files Coverage Δ
optimade/models/entries.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2401873...1cc5b5d. Read the comment docs.

@CasperWA
Copy link
Member Author

The sortable validator has been removed. See discussion and reasoning here.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CasperWA CasperWA merged commit 7aa2388 into master Nov 20, 2019
Road to optimade-python-tools 1.0 automation moved this from In progress to Done Nov 20, 2019
@CasperWA CasperWA deleted the fix_84_add_sortable branch November 20, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Concerns the schema models
Development

Successfully merging this pull request may close these issues.

The sortable field must be added to models
2 participants