New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation tweaks #852
Documentation tweaks #852
Conversation
Processed my suggestions for the text added by 'PR #850 Add some more tutorial-style documentation'.
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 67 67
Lines 3724 3724
=======================================
Hits 3450 3450
Misses 274 274
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers :) Just a few suggested changes and ideas below.
added suggestions CasperW which add references to API documentation. Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…als-Consortia/optimade-python-tools into JPBergsma/Remarks_PR_#850
Removed superfluous single quotes. Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…als-Consortia/optimade-python-tools into JPBergsma/Remarks_PR_#850
Accepted minor changes from code suggestions Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com> Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now, thanks @JPBergsma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers @JPBergsma
Thanks for merging this PR, my first accepted PR for Optimade! |
Processed the suggestion I made for PR #850