Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to AiiDA v1.6.4 and remove CI fix #857

Merged
merged 2 commits into from Jun 24, 2021
Merged

Conversation

CasperWA
Copy link
Member

Closes #855

ml-evs
ml-evs previously approved these changes Jun 23, 2021
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the CI passes! (can re-review after lunch if not)

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #857 (4964943) into master (a4d3424) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          67       67           
  Lines        3724     3724           
=======================================
  Hits         3450     3450           
  Misses        274      274           
Flag Coverage Δ
project 92.64% <ø> (ø)
validator 92.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d3424...4964943. Read the comment docs.

@CasperWA CasperWA requested a review from ml-evs June 23, 2021 14:00
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@CasperWA CasperWA merged commit 5690e1e into master Jun 24, 2021
@CasperWA CasperWA deleted the close_855_revert-CI-fix branch June 24, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CI psycopg2-binary install when aiida-core>1.6.3
3 participants