Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper pip dependency resolver in publish workflow #935

Merged
merged 2 commits into from Sep 2, 2021
Merged

Use proper pip dependency resolver in publish workflow #935

merged 2 commits into from Sep 2, 2021

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 2, 2021 •
edited

Closes #625.

Looks like the initial problem has fixed itself as our deps have updated themselves.

JPBergsma
JPBergsma approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure in your comment is says it close #925
But it actually closes #625

@ml-evs ml-evs merged commit 11477de into master Sep 2, 2021
@ml-evs ml-evs deleted the ml-evs/close_#625 branch September 2, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPBergsma JPBergsma JPBergsma approved these changes

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be properly compliant with the new pip resolver
2 participants
@ml-evs @JPBergsma