restrict pydantic version

[ltalirz]

fix #96

[ml-evs]

Happy to merge this as soon as the tests pass, then we can open a PR to upgrade pydantic/fastapi

[codecov]

Codecov Report

Merging #97 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   85.83%   85.74%   -0.09%     
==========================================
  Files          38       38              
  Lines        2315     2315              
==========================================
- Hits         1987     1985       -2     
- Misses        328      330       +2

Impacted Files	Coverage Δ
...ade/filtertransformers/tests/test_elasticsearch.py	80.64% <0%> (-6.46%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed84012...269cd4d. Read the comment docs.

[ltalirz]

Ahem... what's up with codecov?

[ltalirz]

Anyhow, at least one of the codecov jobs is happy ;-)

[ml-evs]

Thanks for spotting this @ltalirz , perhaps we can keep #96 open until we have agreed on a long term solution?

[mkhorton]

What would need to be changed for us to support pydantic>1? I know they changed some of their API

…

On Thu, Nov 28, 2019 at 04:01, Leopold Talirz ***@***.***> wrote: Merged #97 <#97> into master. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#97?email_source=notifications&email_token=AAWWWRD4EQMLGEOQSVP5SB3QV6XHDA5CNFSM4JSTK7IKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVEZW5FA#event-2838720148>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWWWRDXJDPBIRBQHPXKT5LQV6XHDANCNFSM4JSTK7IA> .

[CasperWA]

What would need to be changed for us to support pydantic>1? I know they changed some of their API

Probably some redefining of validators and reconsidering all imports from pydantic.

I have already created an issue (#101) to discuss it and close, when an appropriate PR handles the upgrade.

I would see it as a huge benefit to the repo to update it ASAP. However, I feel we need to deal with the current PRs first.