Put docs release deployment in separate job #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 92.92% 92.92%
=======================================
Files 67 67
Lines 3787 3787
=======================================
Hits 3519 3519
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ml-evs
approved these changes
Oct 18, 2021
|
(I'm happy if you're happy) |
JPBergsma
reviewed
Oct 18, 2021
|
I'll merge and make another release to test the workflow (v0.16.6). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix part 1 of #976.
There seems to be a permission issue, I believe, after using the push-protected action, however, it may also be due to other things.
In any case, when using
mike deployas the last step in the publish workflow, the workflow fails (see this run).Separating this step into a subsequent job should solve this issue (I saw the same thing for OPTIMADE Gateway, forgot, and needed to do the same there, after which it worked).