Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and pre-commit updates #52

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Linting and pre-commit updates #52

merged 3 commits into from
Jan 29, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 28, 2024

This PR takes some changes from #32 to clean it up a bit.

  • Pre-commit autoupdate
  • Pyupgrade to 3.9+
  • Use recommended mypy + pydantic settings (and make a couple of tweaks so it passes)

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6dafdd2) 44.33% compared to head (b655cd5) 44.31%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #52      +/-   ##
===========================================
- Coverage    44.33%   44.31%   -0.03%     
===========================================
  Files           42       42              
  Lines         4265     4263       -2     
  Branches       868      868              
===========================================
- Hits          1891     1889       -2     
  Misses        2192     2192              
  Partials       182      182              
Files Coverage Δ
src/jobflow_remote/cli/admin.py 31.11% <100.00%> (ø)
src/jobflow_remote/cli/execution.py 84.61% <100.00%> (-1.10%) ⬇️
src/jobflow_remote/cli/jf.py 33.33% <100.00%> (ø)
src/jobflow_remote/cli/jfr_typer.py 95.65% <100.00%> (ø)
src/jobflow_remote/cli/job.py 25.82% <100.00%> (-0.41%) ⬇️
src/jobflow_remote/cli/project.py 45.23% <100.00%> (ø)
src/jobflow_remote/cli/runner.py 28.00% <100.00%> (ø)
src/jobflow_remote/cli/types.py 89.58% <100.00%> (-0.22%) ⬇️
src/jobflow_remote/config/settings.py 92.00% <100.00%> (ø)
src/jobflow_remote/jobs/runner.py 57.96% <ø> (ø)
... and 4 more

@ml-evs ml-evs mentioned this pull request Jan 28, 2024
5 tasks
@ml-evs ml-evs added the CI For issues/PRs relating to CI and linting label Jan 29, 2024
@ml-evs ml-evs force-pushed the ml-evs/linting branch 2 times, most recently from 0b5c787 to 651ba70 Compare January 29, 2024 22:26
@ml-evs ml-evs force-pushed the ml-evs/linting branch 3 times, most recently from 5b47a24 to 58557dd Compare January 29, 2024 23:06
@ml-evs ml-evs merged commit 6d68367 into develop Jan 29, 2024
5 checks passed
@ml-evs ml-evs deleted the ml-evs/linting branch March 26, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI For issues/PRs relating to CI and linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants