Add testing and runtime checks for additional stores #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/test-additional-stores
branch
2 times, most recently
from
7133f25
to
e9d94c4
Compare
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/test-additional-stores
branch
from
4abf99b
to
ce2ced0
Compare
ml-evs
force-pushed
the
ml-evs/test-additional-stores
branch
from
ce2ced0
to
f953403
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #59 +/- ##
===========================================
+ Coverage 44.62% 45.19% +0.57%
===========================================
Files 42 42
Lines 4267 4290 +23
Branches 869 876 +7
===========================================
+ Hits 1904 1939 +35
+ Misses 2184 2173 -11
+ Partials 179 178 -1
|
ml-evs
force-pushed
the
ml-evs/test-additional-stores
branch
2 times, most recently
from
bfd7d74
to
e105ba2
Compare
gpetretto
reviewed
Feb 20, 2024
ml-evs
force-pushed
the
ml-evs/test-additional-stores
branch
from
f4c46d3
to
9073c8c
Compare
ml-evs
changed the title
- Manually connect to gridfs and check for file - Read from GridFS store directly - Fix typo
- Use inspect instead of wrapped annotations, and return `RemoteError` when store is not present - Tweak store tests - Fix bad auto editor import - Dial back the size of test data in the GridFS test
ml-evs
force-pushed
the
ml-evs/test-additional-stores
branch
from
9073c8c
to
92cb740
Compare
gpetretto
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some integration tests that make use of
additional_stores. In the process, I also added a check that makes sure that anyadditional_storesrequested by a job are checked before the job executes, rather than failing afterwards.We could also add a check at submission time for this, which should be a future PR.
Closes #76