Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a shell io object #12

Merged
merged 3 commits into from
May 5, 2023
Merged

Adding a shell io object #12

merged 3 commits into from
May 5, 2023

Conversation

gpetretto
Copy link
Contributor

Included a ShellIO object for execution without a scheduler

davidwaroquiers
davidwaroquiers approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me! For the queue module we can make a separate PR to remove it or you can also remove it directly in this one.

@gpetretto
Copy link
Contributor Author

I removed it here, since we already decided to do that.

@davidwaroquiers davidwaroquiers merged commit 8df6e97 into Matgenix:develop May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwaroquiers davidwaroquiers davidwaroquiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gpetretto @davidwaroquiers