[0.25 XMR BOUNTY] - meile_node_uptime.py - Limit requests to find remote_url

[trinityprivacy]

No description provided.

[MathNodes]

HI - Thanks for the pull request. I tested it and there were some errors with it and some things not needed. I would have went a little different route with this, but I like your attempt. Please refactor your get_remote_url_of_node() code to look like the following and I will merge the pull request and pay the bounty:

def get_remote_url_of_node(self, db, NodeData):
        NodeRemoteURL = {'address' : [], 'url' : []}
        
        c = db.cursor()
        
        for n in NodeData:
            address = n['node_address']
            endpoint = APIURL + '/nodes/' + address
                
            # Retrieve remote_url from the table for nodes that have it stored
            query = f"SELECT remote_url FROM node_uptime WHERE node_address = '{address}';"
            c.execute(query)
            result = c.fetchone()

            if result['remote_url'] == '':        
                endpoint = APIURL + '/nodes/' + address
                remote_url = result['remote_url']
                print(f"Getting remote_url of: {address}", end=":")
                
                try:
                    r = requests.get(endpoint)
                    remote_url = r.json()['result']['node']['remote_url']
                except Exception as e:
                    print(str(e))
                    continue
                print(f"{remote_url}")
            else:
                remote_url = result['remote_url']
                
            NodeRemoteURL['address'].append(n['node_address'])
            NodeRemoteURL['url'].append(remote_url)
        
        return NodeRemoteURL

[trinityprivacy]

Done! Thanks, need to remove some rust here and there :)