Add additional fields to be sent #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
previously approved these changes
Aug 17, 2021
dinhtungdu
suggested changes
Aug 17, 2021
includes/functions/content-sync.php
Outdated
| @@ -180,29 +180,44 @@ function get_post_data( $post ) { | |||
| $content = apply_filters( 'the_content', get_the_content( null, false, $post ) ); | |||
| $content = str_replace( ']]>', ']]>', $content ); | |||
| $canonical_url = wp_get_canonical_url( $post ); | |||
| $keywords = ''; | |||
|
|
|||
| // Support Yoast SEO canonical URL. | |||
There was a problem hiding this comment.
I think we should update the comment to mention keywords.
Comment on lines
+209
to
+220
| 'thumbnailImageUri' => get_the_post_thumbnail_url( $post, 'full' ), | ||
| 'embeddedImagesCount' => Utils\get_number_of_embedded_images( $content ), | ||
| 'classificationCode' => '', | ||
| 'collectionName' => '', | ||
| 'isSponsored' => false, | ||
| 'promoPlainText' => '', | ||
| 'keywords' => $keywords, | ||
| 'creditLine' => '', | ||
| 'ownership' => '', | ||
| 'editorialAccessName' => '', | ||
| 'subtype' => '', | ||
| 'redirectToUrl' => '', |
There was a problem hiding this comment.
Note that we filter the falsy items below, so most of this will be removed. Please see #62 (comment) for more info about omitting empty keys.
There was a problem hiding this comment.
Hi @dinhtungdu
I saw that. I've added the fields even with an empty string to keep track since these fields will be addressed in the future.
felipeelia
approved these changes
Aug 23, 2021
dinhtungdu
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change adds new fields about the post to be sent.
Alternate Designs
Benefits
Possible Drawbacks
Verification Process
Checklist:
Applicable Issues
Changelog Entry
Added new fields to be sent to the API: thumbnailImageUri, embeddedImagesCount, and keywords.