Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HTTP requests in parallel #16

Closed
MatheusRich opened this issue Jan 2, 2023 · 0 comments · Fixed by #19
Closed

Make HTTP requests in parallel #16

MatheusRich opened this issue Jan 2, 2023 · 0 comments · Fixed by #19

Comments

@MatheusRich
Copy link
Owner

MatheusRich commented Jan 2, 2023 •
edited

When we fetch files from a repo, we (currently) make 4 sequential HTTP requests (for each repo!). This is not ideal since it's a blocking operation. Can we leverage async Ruby to make at least the file fetching requests in parallel?

end_of_life/lib/end_of_life/repository.rb

Lines 84 to 87 in da5dc94

fetch_file(".ruby-version"),
fetch_file("Gemfile"),
fetch_file("Gemfile.lock"),
fetch_file(".tool-versions")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch files asynchronously MatheusRich/end_of_life
1 participant
@MatheusRich