Fetch files asynchronously #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusRich
force-pushed
the
async-http-requests
branch
3 times, most recently
from
067298b
to
961b2e1
Compare
This uses the `async` gem to parallelize fetching files from the GitHub API. The app is heavily IO-bound, so this is a good way to speed it up. In my tests, this decreased the time to print results from 25s to around 2s. Note: We're not taking advantage of the FiberScheduler here, because we would need Ruby 3.1 to run async 2.x.
MatheusRich
force-pushed
the
async-http-requests
branch
from
961b2e1
to
c4d6f70
Compare
ioquatix
reviewed
Mar 5, 2024
| repositories.filter { |repo| repo.eol_ruby?(at: max_eol_date) } | ||
| Sync do | ||
| repositories | ||
| .tap { |repos| repos.map { |repo| Async { repo.ruby_version } }.map(&:wait) } |
There was a problem hiding this comment.
If you are doing this a lot, you might find https://github.com/socketry/async-await/blob/main/lib/async/await/enumerable.rb#L24-L30 convenient.
There was a problem hiding this comment.
That is pretty cool, @ioquatix. Could that be included in Async optionally? So one would include async/enumerable to get those methods?
There was a problem hiding this comment.
I think it's better this is a separate gem, as it's a monkey patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
This uses the
asyncgem to parallelize fetching files from the GitHub API. The app is heavily IO-bound, so this is a good way to speed it up.In my tests, this decreased the time to print results from 25s to around 2.5s.