Common JS #55
Merged
Common JS #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- exclude net package test for now because of the lack of server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite the big change. It finally moves
canefrom AMD to CommonJS. While AMD was and is an amazing way to manage dependencies, the community seems to be moving towards commonJS for a variety of reasons.With this PR, all modules have been changed to follow CommonJS syntax, as well as all the tests. Test now also run on tape as I found that a more appropriate way to test node style code as well as its way of handling async code very well.
Since this is a breaking change, the version has been bumped to
1.0.0. Cane is also available via NPM which makes a lot more sense now.