Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordFrequencyData #10

Open
mmatera opened this issue Feb 19, 2023 · 6 comments
Open

WordFrequencyData #10

mmatera opened this issue Feb 19, 2023 · 6 comments

Comments

@mmatera
Copy link
Contributor

mmatera commented Feb 19, 2023

The implementation of WordFrequencyData is wrong. To fix it, we could use https://pypi.org/project/wordfreq/

@rocky
Copy link
Member

rocky commented Feb 19, 2023

This is awesome. But let's do this after the 6.0.0 release.

@mmatera
Copy link
Contributor Author

mmatera commented Feb 20, 2023

This is awesome. But let's do this after the 6.0.0 release.

Actually, I wonder if we want to keep this symbol available in this release, or if we want to comment out it.

@mmatera
Copy link
Contributor Author

mmatera commented Feb 20, 2023

WordFrequency is ok. The problem is WordFrequencyData

@rocky
Copy link
Member

rocky commented Feb 20, 2023

My confusion. I looked at WordFrequencyData with respect to Spacy and yes, it doesn't look like this is easily doable, nor what we currently have, correct.

So yes, let's simplify and remove this for now. I have a one word small addition to a doc that I have been meaning to put in, so I will bundle the removal and this addition together.

@mmatera
Copy link
Contributor Author

mmatera commented Feb 20, 2023

Maybe it is good to have the documentation about what it should do, and then comment out the code, for a future implementation.

@rocky
Copy link
Member

rocky commented Feb 20, 2023

I added information on stuff that is most needed in the next release in #12

There is a lot there, so let's start with that please. Thanks.

For now I have removed this. No need to save anything here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants